Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

only set the activeFrameKey if the tab is already active #9219

Merged
merged 3 commits into from
Jun 4, 2017

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 3, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

probable fix for #9134

Test Plan:
also fixes issue an mac where the first regular tab is restored instead of the pinned tab. Same QA steps as #9134 (minus the waiting)

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver requested review from bsclifton and bbondy June 3, 2017 00:55
@bridiver bridiver force-pushed the pinned-tab-activeFrameKey branch 2 times, most recently from 741907b to b146cb0 Compare June 3, 2017 01:25
@bridiver bridiver self-assigned this Jun 3, 2017
@bridiver bridiver force-pushed the pinned-tab-activeFrameKey branch from b146cb0 to 4129d23 Compare June 3, 2017 01:32
@bsclifton bsclifton force-pushed the pinned-tab-activeFrameKey branch from 4129d23 to c8dcc83 Compare June 4, 2017 07:47
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good- I added some unit tests to capture this new behavior 😄

@bsclifton bsclifton merged commit 80ed6f9 into master Jun 4, 2017
@bsclifton bsclifton deleted the pinned-tab-activeFrameKey branch June 4, 2017 07:54
bsclifton added a commit that referenced this pull request Jun 4, 2017
only set the activeFrameKey if the tab is already active
bsclifton added a commit that referenced this pull request Jun 4, 2017
only set the activeFrameKey if the tab is already active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants