This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
move appStore to main #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sites: [], | ||
| visits: [], | ||
| updateAvailable: false | ||
| }) | ||
|
|
||
| var CHANGE_EVENT = 'change' | ||
| const spawnWindow = () => { |
There was a problem hiding this comment.
spawnWindow seems strange to be inside the store. Could you comment more on why it's here?
There was a problem hiding this comment.
It's really just a temporary location because I didn't have a better place to put it. It will probably be replaced by something like FrameStateUtil
|
Looks good, I think ideally spawnWindow would be outside of the store but I'm good with landing this. |
bridiver
force-pushed
the
move_app_store_to_main
branch
from
f9e7407 to
2c4237f
Compare
This was referenced Jan 27, 2022
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still have a couple more changes I want to put in here, but I want to get this in here to prevent any big merge conflicts