This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Optimize URL bar history and bookmark suggestions (generateNewSuggestionsList()) #8692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayumi
changed the title
ayumi
force-pushed
the
fix/url-bar-autocomplete
branch
2 times, most recently
from
c3fadb9 to
e019197
Compare
ayumi
commented
May 4, 2017
| let bookmarkSites = new Immutable.List() | ||
| const sites = appStoreRenderer.state.get('sites') | ||
| sites.forEach(site => { | ||
| if (!sitesFilter(site)) { |
There was a problem hiding this comment.
Note for reviewers: this is most important change, to filter out non-matching sites as soon as possible to avoid downstream property lookup
bsclifton
reviewed
May 4, 2017
| return false | ||
| } | ||
| const title = site.get('title') | ||
| return location.toLowerCase().includes(urlLocationLower) || |
There was a problem hiding this comment.
Per our discussion on Slack, I wonder if this could be sped up using indexOf? Link you shared: https://jsperf.com/regexp-test-vs-string-includes-vs-string-indexof
There was a problem hiding this comment.
thanks! i've updated this PR to use indexOf instead of includes.
Related to #7453 Auditors: @bsclifton @bbondy
ayumi
force-pushed
the
fix/url-bar-autocomplete
branch
from
e019197 to
90c5b2d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7453
With 10,000 sites, time to run
generateNewSuggestionsList():Auditors: @darkdh @bbondy
git rebase -ito squash commits (if needed).Test Plan:
npm run test -- --grep="^urlBarSuggestions"