Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix Pocket setting l10 #8109

Closed
wants to merge 4 commits into from
Closed

Fix Pocket setting l10 #8109

wants to merge 4 commits into from

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Apr 7, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #7450

Test Plan: (requires up-to-date translations)

  1. Change to a language (Preferences > General > Language) with a up-to-date translation for enableExtension (see en-US/preferences.properties for an example).
  2. Open Preferences > Advanced.
  3. Find the setting Enable Pocket under Extensions.
  4. Make sure the setting matches "Pocket" exactly and is not translated.

@cndouglas cndouglas added this to the 0.14.3 milestone Apr 7, 2017
@cndouglas cndouglas self-assigned this Apr 7, 2017
@cndouglas
Copy link
Author

I made a mess, let me try again.

@cndouglas cndouglas closed this Apr 7, 2017
@cndouglas cndouglas deleted the pocket-setting-l10 branch April 7, 2017 05:17
@cndouglas cndouglas removed their assignment Apr 7, 2017
@cndouglas cndouglas removed this from the 0.14.3 milestone Apr 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant