This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Don't auto-close Brave Payments statements #7699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
npm run add-simulated-payment-history
to add one)Description
It feels like bad UX to have the contribution statement open and then close really quick, especially when the statement itself looks great and has useful information.
This change only prevents the window from auto-closing; it will still prompt to save (we'll need a new Muon before that can be tested. See #7416 for more information)
Fixes #7698
Auditors: @willy-b, @bradleyrichter, @mrose17
git rebase -i
to squash commits (if needed).