This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Build Darwin with app verion #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aekeus
commented
Dec 21, 2015
aekeus
commented
- Moved Darwin build from package.json to build-darwin.js script
- Passed in app version
* Moved Darwin build from package.json to build-darwin.js script * Passed in app version
| @@ -14,7 +14,7 @@ | |||
| "electron-rebuild": "electron-rebuild", | |||
| "lint": "standard", | |||
| "sign-darwin": "./sign-darwin.sh", | |||
| "build-darwin": "NODE_ENV=production webpack && rm -f dist/Brave.dmg && electron-packager . Brave --overwrite --ignore=\"electron-download|electron-rebuild|electron-packager|electron-builder|electron-prebuilt|electron-rebuild|babel-|babel\" --platform=darwin --arch=x64 --version=0.35.1 --icon=res/app.icns", | |||
| "build-darwin": "node ./build-darwin.js", | |||
| "build-win64": "set NODE_ENV=production&&webpack && rm -Rf Brave-win32-x64 && electron-packager . Brave --overwrite --ignore=\"electron-packager|electron-builder|electron-prebuilt|electron-rebuild|babel-|babel\" --platform=win32 --arch=x64 --version=0.35.1 --icon=res/app.ico", | |||
There was a problem hiding this comment.
Win should follow the same please
|
Sounds good. Making the changes now. |
|
Looks good, feel free to merge |
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.