Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

'hide sites with <1% usage' should be default on in about:preferences#payments #7522

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Mar 7, 2017

Fixes #7520

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • bring up a brand new browser with no state
  • go to about:preferences#payments
  • click on 'Advanced Settings'
  • verify that 'Hide sites with less than 1% usage' is enabled

@mrose17 mrose17 added this to the 0.13.6 milestone Mar 7, 2017
@mrose17 mrose17 self-assigned this Mar 7, 2017
@mrose17 mrose17 requested a review from diracdeltas March 7, 2017 22:59
@diracdeltas
Copy link
Member

lgtm with a proper commit message.

in the future, please assign an issue to yourself when you start working on it. i had assigned #7520 to myself and already made a patch for it too.

@mrose17
Copy link
Member Author

mrose17 commented Mar 7, 2017

oops! i thought i was getting it... sorry!

@mrose17 mrose17 changed the title Initial check-in 'hide sites with <1% usage' should be default on in about:preferences#payments Mar 7, 2017
@mrose17 mrose17 merged commit 83c55eb into master Mar 7, 2017
@mrose17 mrose17 deleted the issue-7520 branch March 7, 2017 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants