This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
hook up search in urlbar #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +89,10 @@ class UrlBar extends ImmutableComponent { | |||
| if (this.suggestionsShown && selectedIndex > 0) { | |||
| // load the selected suggestion | |||
| this.refs.urlBarSuggestions.clickSelected() | |||
| } else if (this.props.searchSuggestions && | |||
| (!UrlUtil.isURL(location) || location.includes(' '))) { | |||
There was a problem hiding this comment.
Surprisingly, UrlUtil.isURL(location) returns true if location contains whitespace.
There was a problem hiding this comment.
noted, we might want to bring in UrlUtil into our own repo in the future.
|
Great work, thanks. In the old browser, we had a differentiator for Command+L vs Command+K for privacy reasons. Please merge at will. |
Auditors: @bridiver
|
Sorry accidentally committed that last one into your branch. I'll just merge it all in. |
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known bug: search autocomplete doesn't work for multi-word searches
Auditors: @bbondy