Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

numerous small adjustments to buttons and some other style fixes #5526

Merged
merged 5 commits into from
Nov 11, 2016

Conversation

bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Nov 10, 2016

@jkup jkup self-assigned this Nov 10, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 10, 2016

First run through on a Mac

The bad

noticed the home button is not horizontally aligned:
screen shot 2016-11-10 at 9 15 58 am

the stop button I think need to go left by 1px
screen shot 2016-11-10 at 9 17 22 am

The good

Here's what does look great:

  • rest of buttons 👍
  • using black w/ 10% alpha instead of gray on footer for add/edit bookmark hanger
  • new brave button
  • new tab button looks perfect! 👍
  • new gray color on newtab much easier to read (time saved, etc)
  • new height for extension button looks good! pocket not huge anymore 😛

@bradleyrichter
Copy link
Contributor Author

thanks. I'll fix...

@srirambv
Copy link
Collaborator

@bradleyrichter This is how it looks on Windows. The mouse hover isn't very prominent. Plus the stop button looks a little lighter than the refresh and the home buttons

image

@jkup
Copy link
Contributor

jkup commented Nov 10, 2016

Colors look great! Agree with other fixes on here then we're good to go!

@bradleyrichter
Copy link
Contributor Author

ok, all of the above should be fixed but we still need a windows review to check the button alignments.

@bbondy
Copy link
Member

bbondy commented Nov 11, 2016

++ merging.

@bbondy bbondy merged commit 7815cfc into master Nov 11, 2016
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. and removed design A design change, especially one which needs input from the design team. labels Nov 11, 2016
@bsclifton bsclifton deleted the polishfest-one branch November 11, 2016 15:22
@bradleyrichter
Copy link
Contributor Author

@bbondy @bsclifton @jkup This will need windows adjustment unless all planets aligned.

@srirambv
Copy link
Collaborator

@bradleyrichter @jkup @bsclifton

Stop loading SVG is still not fixed on Windows
Refresh SVG is still not center aligned

image

Clearly visible when zoomed in
image

@luixxiul
Copy link
Contributor

Stop loading SVG is still not fixed on Windows

+1 on macOS

@luixxiul
Copy link
Contributor

#5737 should fix the alignment issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
misc/button polish Nice to have — usually related to front-end/visual tasks. QA/checked-macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants