This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
numerous small adjustments to buttons and some other style fixes #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks. I'll fix... |
@bradleyrichter This is how it looks on Windows. The mouse hover isn't very prominent. Plus the stop button looks a little lighter than the refresh and the home buttons |
Colors look great! Agree with other fixes on here then we're good to go! |
ok, all of the above should be fixed but we still need a windows review to check the button alignments. |
++ merging. |
luixxiul
added
design
A design change, especially one which needs input from the design team.
polish
Nice to have — usually related to front-end/visual tasks.
and removed
design
A design change, especially one which needs input from the design team.
labels
Nov 11, 2016
@bbondy @bsclifton @jkup This will need windows adjustment unless all planets aligned. |
This was referenced Nov 14, 2016
@bradleyrichter @jkup @bsclifton Stop loading SVG is still not fixed on Windows |
+1 on macOS |
4 tasks
#5737 should fix the alignment issue. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jkup @bsclifton
Fix #5527