This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Fixing bookmarks toolbar "hover after click" behavior on folders #4361
Merged
+297
−59
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Fixing bookmarks toolbar "hover after click" behavior on folders
When context menu is expanded for a bookmark folder, mousing over other folders will auto-expand them (closing your previous folder's context menu). Matching behavior in Chrome, mousing over non-folders will hide the menu. Fixes #1725 Also includes: - Added constant to faviconUtils for default icon size (referenced from bookmarksToolbar component) - Moved bookmarksToolbar component and faviconUtils to new directory structure Auditors: @bbondy @darkdh Test Plan: 1. Launch Brave and ensure you have bookmarks toolbar showing with at least 2 folders and 1 non-folder 2. Click one of the folders in bookmarks toolbar and confirm it opens 3. Mouse over the other folder and confirm it auto-expands the menu 4. Mouse over a non-folder (ex: a bookmark) and confirm it hides the menu 5. Mouse back over a folder and confirm it auto-expands it again 6. Click anywhere to dismiss the context menu
- v0.27.3
- v0.27.2
- v0.27.1
- v0.27.0
- v0.26.0dev
- v0.25.304dev
- v0.25.303dev
- v0.25.302dev
- v0.25.300beta
- v0.25.217
- v0.25.217beta
- v0.25.204nightly
- v0.25.203
- v0.25.202nightly
- v0.25.201nightly
- v0.25.3beta
- v0.25.2dev
- v0.25.1dev
- v0.25.0dev
- v0.24.2developer
- v0.24.0dev
- v0.23.207dev
- v0.23.206dev
- v0.23.205dev
- v0.23.204dev
- v0.23.204beta
- v0.23.203beta
- v0.23.202beta
- v0.23.201beta
- v0.23.107dev
- v0.23.105dev
- v0.23.104dev
- v0.23.103dev
- v0.23.102dev
- v0.23.100beta
- v0.23.80dev
- v0.23.79dev
- v0.23.78beta
- v0.23.77dev
- v0.23.75dev
- v0.23.74dev
- v0.23.73dev
- v0.23.72
- v0.23.70beta
- v0.23.69beta
- v0.23.39dev
- v0.23.38dev
- v0.23.37dev
- v0.23.36dev
- v0.23.35dev
- v0.23.34dev
- v0.23.33dev
- v0.23.32beta
- v0.23.31dev
- v0.23.21beta
- v0.23.19dev
- v0.23.18dev
- v0.23.17dev
- v0.23.16dev
- v0.23.15dev
- v0.23.14beta
- v0.23.13beta
- v0.23.12beta
- v0.23.11beta
- v0.23.8beta
- v0.23.7developer
- v0.23.6developer
- v0.23.4developer
- v0.23.3developer
- v0.23.2developer
- v0.22.810dev
- v0.22.808dev
- v0.22.807dev
- v0.22.806beta
- v0.22.805beta
- v0.22.804beta
- v0.22.802beta
- v0.22.801beta
- v0.22.727dev
- v0.22.726dev
- v0.22.725dev
- v0.22.724dev
- v0.22.723dev
- v0.22.722dev
- v0.22.721dev
- v0.22.719dev
- v0.22.718beta
- v0.22.716beta
- v0.22.714dev
- v0.22.713dev
- v0.22.712dev
- v0.22.711dev
- v0.22.710beta
- v0.22.709dev
- v0.22.708dev
- v0.22.707beta
- v0.22.706beta
- v0.22.703beta
- v0.22.702beta
- v0.22.701beta
- v0.22.669dev
- v0.22.667dev
- v0.22.666dev
- v0.22.665dev
- v0.22.664dev
- v0.22.663
- v0.22.662
- v0.22.650developer
- v0.22.109beta
- v0.22.108beta
- v0.22.106beta
- v0.22.105beta
- v0.22.103beta
- v0.22.101beta
- v0.22.22dev
- v0.22.21dev
- v0.22.21-2
- v0.22.20dev
- v0.22.19dev
- v0.22.18dev
- v0.22.17dev
- v0.22.16dev
- v0.22.15dev
- v0.22.14beta
- v0.22.13dev
- v0.22.12dev
- v0.22.11dev
- v0.22.10dev
- v0.22.9dev
- v0.22.8beta
- v0.22.7beta
- v0.22.6beta
- v0.22.5beta
- v0.22.4beta
- v0.22.3developer
- v0.22.2
- v0.22.2nightly
- v0.22.0Developer
- v0.21.658beta
- v0.21.657beta
- v0.21.656beta
- v0.21.654beta
- v0.21.652beta
- v0.21.651beta
- v0.21.24dev
- v0.21.23dev
- v0.21.21dev
- v0.21.20dev
- v0.21.19dev
- v0.21.18dev
- v0.21.17beta
- v0.21.16beta
- v0.21.15beta
- v0.21.12beta
- v0.21.11beta
- v0.21.9beta
- v0.21.7beta
- v0.21.5developer
- v0.21.4developer
- v0.21.3developer
- v0.21.2developer
- v0.20.46dev
- v0.20.45
- v0.20.44
- v0.20.43
- v0.20.42dev
- v0.20.41dev
- v0.20.40dev
- v0.20.39dev
- v0.20.38dev
- v0.20.37dev
- v0.20.36dev
- v0.20.35dev
- v0.20.33dev
- v0.20.32dev
- v0.20.31dev
- v0.20.30dev
- v0.20.29dev
- v0.20.27dev
- v0.20.25dev
- v0.20.24dev
- v0.20.23dev
- v0.20.22beta
- v0.20.21beta
- v0.20.20beta
- v0.20.19beta
- v0.20.17beta
- v0.20.16beta
- v0.20.15beta
- v0.20.14beta
- v0.20.13beta
- v0.20.12beta
- v0.20.11beta
- v0.20.10beta
- v0.20.9beta
- v0.20.8beta
- v0.20.7beta
- v0.20.6beta
- v0.20.5beta
- v0.20.4beta
- v0.20.3developer
- v0.20.0
- v0.19.147dev
- v0.19.146dev
- v0.19.145dev
- v0.19.144dev
- v0.19.143dev
- v0.19.142dev
- v0.19.141dev
- v0.19.140dev
- v0.19.139dev
- v0.19.138dev
- v0.19.137dev
- v0.19.136dev
- v0.19.135dev
- v0.19.134dev
- v0.19.133dev
- v0.19.132dev
- v0.19.131dev
- v0.19.130dev
- v0.19.129dev
- v0.19.128dev
- v0.19.127dev
- v0.19.126dev
- v0.19.125dev
- v0.19.124dev
- v0.19.123dev
- v0.19.122dev
- v0.19.121dev
- v0.19.120dev
- v0.19.119dev
- v0.19.118dev
- v0.19.117dev
- v0.19.116dev
- v0.19.115dev
- v0.19.114dev
- v0.19.113dev
- v0.19.112dev
- v0.19.111
- v0.19.110dev
- v0.19.109
- v0.19.108
- v0.19.108nightly
- v0.19.107
- v0.19.106
- v0.19.105dev
- v0.19.104dev
- v0.19.103
- v0.19.102nightly
- v0.19.101nightly
- v0.19.100dev
- v0.19.99dev
- v0.19.98
- v0.19.96
- v0.19.95dev
- v0.19.94dev
- v0.19.93dev
- v0.19.92dev
- v0.19.91dev
- v0.19.90dev
- v0.19.89dev
- v0.19.88dev
- v0.19.87dev
- v0.19.86dev
- v0.19.82dev
- v0.19.81dev
- v0.19.80dev
- v0.19.79dev
- v0.19.75dev
- v0.19.74dev
- v0.19.72dev
- v0.19.71dev
- v0.19.70dev
- v0.19.69dev
- v0.19.68dev
- v0.19.67dev
- v0.19.66dev
- v0.19.65dev
- v0.19.62dev
- v0.19.61dev
- v0.19.60dev
- v0.19.58beta
- v0.19.57developer
- v0.19.54beta
- v0.19.53dev
- v0.19.52dev
- v0.19.50beta
- v0.19.49dev
- v0.19.48dev
- v0.19.46dev
- v0.19.45beta
- v0.19.44beta
- v0.19.43beta
- v0.19.42beta
- v0.19.41beta
- v0.19.39beta
- v0.19.38beta
- v0.19.37beta
- v0.19.36beta
- v0.19.35beta
- v0.19.34beta
- v0.19.33beta
- v0.19.30beta
- v0.19.29beta
- v0.19.28beta
- v0.19.27beta
- v0.19.25beta
- v0.19.24beta
- v0.19.23beta
- v0.19.20beta
- v0.19.17beta
- v0.19.16beta
- v0.19.15beta
- v0.19.14beta
- v0.19.13beta
- v0.19.12beta
- v0.19.9beta
- v0.19.7beta
- v0.19.6beta
- v0.19.5beta
- v0.19.3beta
- v0.19.2beta
- v0.19.1
- v0.19.1beta
- v0.18.36dev
- v0.18.35dev
- v0.18.34dev
- v0.18.32dev
- v0.18.31dev
- v0.18.30dev
- v0.18.29dev
- v0.18.28dev
- v0.18.27dev
- v0.18.26dev
- v0.18.25dev
- v0.18.24dev
- v0.18.23dev
- v0.18.22dev
- v0.18.21dev
- v0.18.20dev
- v0.18.19dev
- v0.18.18dev
- v0.18.17dev
- v0.18.16dev
- v0.18.15dev
- v0.18.14dev
- v0.18.13beta
- v0.18.12beta
- v0.18.11beta
- v0.18.10beta
- v0.18.9beta
- v0.18.8beta
- v0.18.7beta
- v0.18.6beta
- v0.18.5beta
- v0.18.4beta
- v0.18.1beta
- v0.17.19dev
- v0.17.18dev
- v0.17.17dev
- v0.17.16dev
- v0.17.15dev
- v0.17.14dev
- v0.17.13dev
- v0.17.12dev
- v0.17.11dev
- v0.17.10dev
- v0.17.9dev
- v0.17.7dev
- v0.17.6dev
- v0.17.4dev
- v0.17.3dev
- v0.17.2dev
- v0.17.1.5dev
- v0.17.1dev
- v0.17.0dev
- v0.16.13dev
- v0.16.12dev
- v0.16.11
- v0.16.11dev
- v0.16.10dev
- v0.16.9dev
- v0.16.8dev
- v0.16.7dev
- v0.16.6dev
- v0.16.5dev
- v0.16.4dev
- v0.16.3dev
- v0.16.2dev
- v0.16.1dev
- v0.16.0dev
- v0.15.314
- v0.15.314dev
- v0.15.313dev
- v0.15.312dev
- v0.15.311dev
- v0.15.310dev
- v0.15.309dev
- v0.15.308dev
- v0.15.307dev
- v0.15.306dev
- v0.15.305dev
- v0.15.304dev
- v0.15.303dev
- v0.15.302dev
- v0.15.301dev
- v0.15.300dev-Preview4
- v0.15.3dev-Preview3
- v0.15.2dev-RC1
- v0.15.2dev-Preview2
- v0.15.2dev
- v0.15.1dev-RC1
- v0.15.1dev-Preview1
- v0.15.1dev
- v0.15.0dev-RC6
- v0.15.0dev-RC5
- v0.15.0dev-RC4
- v0.15.0dev-RC3
- v0.15.0dev-RC2
- v0.15.0dev-RC1
- v0.15.0dev
- v0.14.2dev-RC2
- v0.14.2dev-RC1
- v0.14.2dev-Preview3
- v0.14.2dev-Preview2.1
- v0.14.2dev-Preview2
- v0.14.2dev-Preview1
- v0.14.1dev-RC1
- v0.14.1dev
- v0.14.0dev-RC3
- v0.14.0dev-RC2
- v0.14.0dev-RC1
- v0.14.0dev-Preview7
- v0.14.0dev-Preview6
- v0.14.0dev-Preview5
- v0.14.0dev-Preview4
- v0.14.0dev-Preview3
- v0.14.0dev-Preview2
- v0.14.0dev-Preview1
- v0.14.0dev
- v0.13.5dev-RC3
- v0.13.5dev-RC2
- v0.13.5dev-RC1
- v0.13.5dev-Preview3
- v0.13.5dev-Preview2
- v0.13.5dev-Preview1
- v0.13.5dev
- v0.13.4dev-RC1
- v0.13.4dev
- v0.13.3dev-RC5
- v0.13.3dev-RC4
- v0.13.3dev-RC3
- v0.13.3dev-RC2
- v0.13.3dev-RC1
- v0.13.3dev-Preview2
- v0.13.3dev-Preview1
- v0.13.3dev
- v0.13.2dev-RC7
- v0.13.2dev-RC6
- v0.13.2dev-RC5
- v0.13.2dev-RC4
- v0.13.2dev-RC3
- v0.13.2dev-RC2
- v0.13.2dev-RC1
- v0.13.2dev-Preview1
- v0.13.2dev
- v0.13.1dev-RC2
- v0.13.1dev-RC1
- v0.13.1dev
- v0.13.0dev-RC9
- v0.13.0dev-RC8
- v0.13.0dev-RC7
- v0.13.0dev-RC6
- v0.13.0dev-RC5
- v0.13.0dev-RC4
- v0.13.0dev-RC3
- v0.13.0dev-RC2
- v0.13.0dev-RC1
- v0.13.0dev-Preview10
- v0.13.0dev-Preview9
- v0.13.0dev-Preview8
- v0.13.0dev-Preview7
- v0.13.0dev-Preview5
- v0.13.0dev-Preview4
- v0.13.0dev-Preview3
- v0.13.0dev-Preview2
- v0.13.0dev-Preview1
- v0.13.0dev
- v0.12.15dev-RC3
- v0.12.15dev-RC1
- v0.12.15dev
- v0.12.14dev-RC1
- v0.12.14dev
- v0.12.13dev-RC2
- v0.12.13dev
- v0.12.12dev-RC1
- v0.12.12dev
- v0.12.11dev-RC1
- v0.12.11dev
- v0.12.10dev-RC1
- v0.12.10dev-Preview1
- v0.12.10dev
- v0.12.9dev-RC1
- v0.12.9dev-Preview3
- v0.12.9dev-Preview2
- v0.12.9dev-Preview1
- v0.12.9dev
- v0.12.8dev-RC1
- v0.12.8dev-Preview3
- v0.12.8dev-Preview2
- v0.12.8dev-Preview1
- v0.12.8dev
- v0.12.7dev-RC2
- v0.12.7dev-RC1
- v0.12.7dev-Preview1
- v0.12.7dev
- v0.12.6dev-RC2
- v0.12.6dev-RC1
- v0.12.6dev-Preview2
- v0.12.6.dev-Preview1
- v0.12.6dev-Preview1
- v0.12.6dev
- v0.12.5dev-RC4
- v0.12.5dev-RC3
- v0.12.5dev-RC2
- v0.12.5dev-RC1
- v0.12.5dev-Preview2
- v0.12.5dev-Preview1
- v0.12.5dev
- untagged-d47e6c397e6dd648074d
- sync-v2-preview
- qwer
- do-not-publish-me
- asdf
- 0.20.x-exp-proxy-fix-4
- 0.20.x-exp-proxy-fix-3
- 0.20.x-exp-proxy-fix-2
- 0.20.x-exp-proxy-fix-1
commit 1ede4e9bcf2255b624c108122e8631ff7ec1a605
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that ideally this should trigger something like an
onMouseOverBookmarkFolder
action with whatever params are needed to allow the windowstore (browser process eventually) to update the state rather than having the logic here to open context menus and update state. The are two reasons for this:electron.remote
methods) in preparation for moving them to the browser processThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bridiver:
showBookmarkFolderMenu
) doesn't useelectron.remote
. However, there are methods in that file (contextMenus.js
) which do (specifically for creating / showing popup menu templates)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at
this.props.showBookmarkFolderMenu
which at first looked like it called the electron api directly, but it callssetContextMenuDetails
which eventually triggers a call the remote api. The windowStore really should directly care about any of this, the logic itself should be in a "reducer" similarextensionState
. In the flux/redux model that is exactly where the logic is supposed to go. The UI should just fire off events and react to state changes. We have a bit of code to untangle because actions shouldn't call other actions, but some of the actions are "setters" and aren't written in a way that makes it easy to reuse the login in them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented feedback- ready for re-review @bridiver 😄