This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add bravery menu to the hamburger menu #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| // whether the current page is bookmarked. needed to re-initialize the | ||
| // application menu. | ||
| settings.bookmarked = this.refs.navBar.bookmarked |
There was a problem hiding this comment.
I guess we're no longer using refs? lmk if i should update this to be consistent with https://github.com/brave/browser-laptop/pull/316/files
There was a problem hiding this comment.
yes the approach in https://github.com/brave/browser-laptop/pull/316/files is better thanks.
|
Couple of minor things, please feel free to merge with edits. |
diracdeltas
added a commit
that referenced
this pull request
Jan 29, 2016
Add bravery menu to the hamburger menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bbondy