-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
589a62e
to
469e636
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does useProxy
here still serve a purpose? https://github.com/brave/browser-laptop/pull/14774/files#diff-3cdfdb124f718787d584e9e2b82fcedcR1638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment left, else looks good to me.
Not critical for this PR but we can probably go ahead and remove the use of useProxy
in the bat-client
at some point if this was the only purpose it served.
Resolves brave#14763 Auditors: Test Plan:
@ryanml yeah we can remove it in bat-client as well |
469e636
to
e9f6f29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
@NejcZdovc is there anything in bat-client that uses PIA? (if so we should get rid of that too) |
@diracdeltas no we don't use any reference to PIA in bat-client |
Resolves #14763
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests