Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes PIA #14774

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Removes PIA #14774

merged 1 commit into from
Jul 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 18, 2018

Resolves #14763

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • make sure that PIA is not referenced any more
    image
  • run browser with LEDGER_VERBOSE and make sure that requests don't go through PIA

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left, else looks good to me.

Not critical for this PR but we can probably go ahead and remove the use of useProxy in the bat-client at some point if this was the only purpose it served.

Resolves brave#14763

Auditors:

Test Plan:
@NejcZdovc
Copy link
Contributor Author

@ryanml yeah we can remove it in bat-client as well

@NejcZdovc NejcZdovc requested a review from ryanml July 18, 2018 05:58
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@diracdeltas
Copy link
Member

@NejcZdovc is there anything in bat-client that uses PIA? (if so we should get rid of that too)

@NejcZdovc
Copy link
Contributor Author

@diracdeltas no we don't use any reference to PIA in bat-client

@NejcZdovc NejcZdovc merged commit c07fe93 into brave:master Jul 18, 2018
NejcZdovc added a commit that referenced this pull request Jul 18, 2018
NejcZdovc added a commit that referenced this pull request Jul 18, 2018
@NejcZdovc
Copy link
Contributor Author

master c07fe93
0.24 3258025
0.23 a38be75

@diracdeltas diracdeltas mentioned this pull request Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants