This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Ensuring publishers file is read from as little possible #14743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
publisherInfoData
as an in-memory storage of the publisher verification data. When the publishers file is written to, this variable receives a copy of the information. We should look to this variable first for the data rather than reading from the file. In the case that we restart the browser, we should read the file but once then copy that info in to memory.This gives a max file read per session of 1.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests