This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Revert "Merge pull request #13504 from jasonrsadler/gen-backup-remind" #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 99711a9. Auditors: @jasonrsadler
|
looks like there are a problem with unit tests on master (preventing this from being merged) Reverting this worked fine (lint / unit tests passed) on 0.22.x-release3 and 0.23.x. When I run |
|
@bsclifton this PR is a problem #14073 |
|
@davidtemkin and @mandar-brave are good to undo revert |
|
Closing as (after discussion) we'd like to keep this feature |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #13504 in master only
Already reverted in 0.22.x-release3 and 0.23.x (see #13504 (comment))
Auditors: @jasonrsadler