Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Track isAudioMuted so that a re-render is triggered via ReduxCompon… #12466

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Track isAudioMuted so that a re-render is triggered via ReduxCompon… #12466

merged 1 commit into from
Jan 3, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 2, 2018

…ent when state changes

Fixes #10545

Auditors: @NejcZdovc

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

See #10545

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.20.x (Beta Channel) milestone Jan 2, 2018
@bsclifton bsclifton self-assigned this Jan 2, 2018
@bsclifton bsclifton requested a review from NejcZdovc January 2, 2018 21:19
@NejcZdovc
Copy link
Contributor

@bsclifton so if I understand correctly this PR, we only have this prop here so that we trigger re-render? If this is the case, can you please add a small comment about it so that someone will not remove it (it's not used anywhere).

@bsclifton
Copy link
Member Author

bsclifton commented Jan 3, 2018

@NejcZdovc that is correct. Will update with comment 😄

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment why we have it in

@bsclifton
Copy link
Member Author

@NejcZdovc updated 😄 👍

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ++

@NejcZdovc NejcZdovc merged commit eefeaad into brave:master Jan 3, 2018
@bsclifton bsclifton deleted the fix-mute-context-menu branch January 3, 2018 07:19
NejcZdovc added a commit that referenced this pull request Jan 3, 2018
Track `isAudioMuted` so that a re-render is triggered via ReduxCompon…
NejcZdovc added a commit that referenced this pull request Jan 3, 2018
Track `isAudioMuted` so that a re-render is triggered via ReduxCompon…
@NejcZdovc
Copy link
Contributor

master eefeaad
0.21 8b83b27
0.20 707522c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants