This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Simplify logic for when a webview needs to be added #1213
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From a screenshot on #browser, Serg seems to have gotten in a staste where the webview wasn't added to the dom yet, or possibly it was because the dom wasn't ready yet. Anyway I'd like to rule this out in case a child node isn't removed immediately Auditors: @diracdeltas
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a screenshot on #browser, Serg seems to have gotten in a staste where the webview wasn't added to the dom yet, or possibly it was because the dom wasn't ready yet. Anyway I'd like to rule this out in case a child node isn't removed immediately
Auditors: @diracdeltas