This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Prevent firing updatePinnedTabs repeatedly for the same state/window combination #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Nov 9, 2017
| @@ -72,19 +75,26 @@ const siteMatchesTab = (site, tab) => { | |||
| return matchesLocation && matchesPartition | |||
| } | |||
|
|
|||
| const updatePinnedTabs = (win) => { | |||
| const updatePinnedTabs = (win, appState) => { | |||
There was a problem hiding this comment.
not sure why we are passing state in, which we get in the same way as we did before?
There was a problem hiding this comment.
Seems like a better practice and more consistent with the way other functions are structured. Plus it avoids calling AppStore.getstate multiple times in a row for multiple windows (though yes I know it is a very cheap function) and it feels cleaner and easier to test. Plus I’m not sure at all why the function had the AppStore require inside the function before...?? Was it to stop the module from being evaluated in case it wasn’t ever required in the process (I can’t imagine that happening)
petemill
force-pushed
the
fix-pinned-tabs-repeating
branch
from
9e1716d to
67024e3
Compare
bsclifton
reviewed
Dec 24, 2017
| // cache that this state has been updated for this window, | ||
| // so we do not repeat the operation until | ||
| // this specific part of the state has changed | ||
| // See |
There was a problem hiding this comment.
looks like your comment just drops off here 😛
…combination Use WeakMap so that we lose the reference to an old state when we lose the reference to an old window Fix brave#11861
bsclifton
force-pushed
the
fix-pinned-tabs-repeating
branch
from
67024e3 to
dfd3d54
Compare
bsclifton
approved these changes
Dec 24, 2017
bsclifton
added a commit
that referenced
this pull request
Dec 24, 2017
Prevent firing updatePinnedTabs repeatedly for the same state/window combination
bsclifton
added a commit
that referenced
this pull request
Dec 24, 2017
Prevent firing updatePinnedTabs repeatedly for the same state/window combination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11861 (and #12377)
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Steps to Reproduce
This can then cause some weird errors when a window's tab state is out of sync with what it should have.
Expected result:
Previous actual result:
Reviewer Checklist:
Tests