This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Use muon's tab_strip_model for driving index and active #10640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10640 +/- ##
==========================================
- Coverage 54.41% 54.07% -0.35%
==========================================
Files 246 247 +1
Lines 21368 21522 +154
Branches 3320 3332 +12
==========================================
+ Hits 11628 11638 +10
- Misses 9740 9884 +144
|
bridiver
reviewed
Aug 23, 2017
| @@ -319,7 +318,7 @@ const frameOptsFromFrame = (frame) => { | |||
| * Adds a frame specified by frameOpts and newKey and sets the activeFrameKey | |||
| * @return Immutable top level application state ready to merge back in | |||
| */ | |||
| function addFrame (state, frameOpts, newKey, partitionNumber, openInForeground, insertionIndex) { | |||
| function addFrame (state, frameOpts, newKey, partitionNumber, openInForeground, insertionIndex, active) { | |||
There was a problem hiding this comment.
active doesn't appear to be used?
bbondy
force-pushed
the
tab-strip-master
branch
2 times, most recently
from
5805ca0 to
836d69e
Compare
bbondy
modified the milestones:
0.18.x Hotfix 1 (Release Channel),
0.18.x Hotfix 2 (Release Channel)
bbondy
force-pushed
the
tab-strip-master
branch
2 times, most recently
from
c008832 to
45da478
Compare
bsclifton
reviewed
Aug 30, 2017
| @@ -158,6 +119,7 @@ const tabsReducer = (state, action, immutableAction) => { | |||
| break | |||
| case appConstants.APP_TAB_UPDATED: | |||
| state = tabState.maybeCreateTab(state, action) | |||
| // tabs.debugTabs(state) | |||
There was a problem hiding this comment.
that's on purpose because I toggle it often
bsclifton
reviewed
Aug 30, 2017
app/browser/reducers/tabsReducer.js
Outdated
| const windowIdOfTabBeingRemoved = tabState.getWindowId(state, tabId) | ||
| state = tabs.updateTabsStateForWindow(state, windowIdOfTabBeingRemoved) | ||
| } | ||
| console.log('calling removeTabByTabId ofr tabId:', tabId) |
There was a problem hiding this comment.
console.log that we can remove
bsclifton
reviewed
Aug 31, 2017
| break | ||
| } | ||
| case appConstants.APP_TAB_MOVED: | ||
| state = tabs.updateTabsStateForAttachedTab(state, action.get('tabId')) |
There was a problem hiding this comment.
appConstants.APP_TAB_MOVED can be grouped with appConstants.APP_TAB_ATTACHED (since they have the same code)
There was a problem hiding this comment.
they are 2 diff things though so I don't think they should be.
bsclifton
approved these changes
Aug 31, 2017
bbondy
modified the milestones:
0.19.x (Beta Channel),
0.18.x Hotfix 2 (Release Channel)
bbondy
force-pushed
the
tab-strip-master
branch
from
45da478 to
22a1c33
Compare
8 tasks
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
Use muon's tab_strip_model for driving index and active
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
From a review comment on #10640
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
From a review comment on #10640
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
From a review comment on #10640
bbondy
added a commit
that referenced
this pull request
Aug 31, 2017
From a review comment on #10640
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR that is rebased on 0.18.x milestone.
This fix first landed in 0.18.x hotfix.
It is only tracked in 0.19.x because it's rebased differently and we want to not lose track of the fixes for uplifting once 4.4 muon builds are ready.
Fix #9083
Fix #9385
Fix #9671
Fix #9722
Fix #10038
Fix #10384
Fix #10436
Fix #10532
Fix #10561
and probably several others.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests