Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

preferences don't work on linux #743

Closed
diracdeltas opened this issue Feb 11, 2016 · 3 comments · Fixed by brave/muon#14
Closed

preferences don't work on linux #743

diracdeltas opened this issue Feb 11, 2016 · 3 comments · Fixed by brave/muon#14
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

#666 is still happening on linux

@bbondy
Copy link
Member

bbondy commented Feb 11, 2016

CC @bridiver because it's probably contentScript not loading related.

Do ad insertions happen?

@diracdeltas
Copy link
Member Author

yep, ad insertions work
On Feb 11, 2016 3:31 PM, "Brian R. Bondy" [email protected] wrote:

CC @bridiver https://github.com/bridiver because it's probably
contentScript not loading related.

Do ad insertions happen?


Reply to this email directly or view it on GitHub
#743 (comment)
.

@bbondy
Copy link
Member

bbondy commented Feb 14, 2016

I think you must have had an old build of electron or something because I verified and content scripts aren't loaded. So ad insertions not working with latest either. This is also causing theme colors not to work on linux. Path of the content script seems to be passed correctly

/home/bbondy/projects/brave/browser-laptop/node_modules/electron-prebuilt/dist/brave --type=renderer --no-sandbox --lang=en-US --node-integration=false --guest-instance-id=1 --enable-blink-features --content-scripts=file:///home/bbondy/projects/brave/browser-laptop/app/content/webviewPreload.js

@bridiver ca you take a look?

@bbondy bbondy added this to the 0.7.16 milestone Feb 21, 2016
bridiver added a commit to brave/muon that referenced this issue Feb 23, 2016
bridiver added a commit to brave/muon that referenced this issue Feb 23, 2016
bbondy pushed a commit to brave/muon that referenced this issue Mar 13, 2016
bbondy pushed a commit to brave/muon that referenced this issue Mar 15, 2016
bbondy pushed a commit to brave/muon that referenced this issue Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants