Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Session tab/private tab icon and text is too spaced out #6511

Closed
srirambv opened this issue Jan 3, 2017 · 3 comments
Closed

Session tab/private tab icon and text is too spaced out #6511

srirambv opened this issue Jan 3, 2017 · 3 comments
Assignees
Milestone

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 3, 2017

Test plan

#6900 (comment)


Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Session tab/private tab icon and text is too spaced out

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/newtab regression release/not-blocking labels Jan 3, 2017
@srirambv srirambv added this to the 0.13.1 milestone Jan 3, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jan 4, 2017

This should be fixed after #5918 is merged /cc: @cezaraugusto

@cezaraugusto
Copy link
Contributor

yes all content inside tab was changed there, also dynamic items such as private and play icons are now displayed on right position instead of left.

@bsclifton
Copy link
Member

@cezaraugusto can you rebase your commit and also reference this one as one that'll be fixed using auto-closing keywords? 😄

@cezaraugusto cezaraugusto self-assigned this Jan 15, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
@bbondy bbondy modified the milestones: 0.13.2, 0.13.1 Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 30, 2017
cezaraugusto added a commit that referenced this issue Feb 1, 2017
cezaraugusto added a commit that referenced this issue Feb 3, 2017
cezaraugusto added a commit that referenced this issue Feb 5, 2017
bsclifton pushed a commit that referenced this issue Feb 6, 2017
@bsclifton bsclifton added this to the 0.13.3 milestone Feb 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants