Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression : autocomplete is deleting the first character typed in the url bar #5529

Closed
alexwykoff opened this issue Nov 10, 2016 · 2 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When changing tabs and wanting to visit github.com, I clicked in the url bar and found the first character was deleted.

Expected behavior:
Whatever I type in the url bar should be respected.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version:
    0.12.9 RC1

  • Steps to reproduce:

    1. Give focus to tab A
    2. Click on tab B
    3. Click on the url bar in tab B
    4. Quickly type a url like github.com
  • Screenshot if needed:

  • Any related issues:

@diracdeltas
Copy link
Member

diracdeltas commented Nov 12, 2016

this may be because the URLbar is getting selected after the first character is typed, so whatever is typed afterward overrides the initial character. just a thought since i'm having a hard time repro-ing it but have seen it come up.

diracdeltas added a commit that referenced this issue Nov 12, 2016
previously it seems that the urlbar was getting selected
every time the react select state was updated; yet then the
react selected state would be updated to false.

this may fix #5529

Auditors: @bbondy

Test Plan:
follow Alex's test steps in #5529
and check that the first character is not deleted.
@bbondy
Copy link
Member

bbondy commented Nov 12, 2016

I think this might be fixed by:
fcde124

Please test and re-open if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants