Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Can't change default search via preferences #4695

Closed
bsclifton opened this issue Oct 12, 2016 · 0 comments · Fixed by #4696
Closed

Can't change default search via preferences #4695

bsclifton opened this issue Oct 12, 2016 · 0 comments · Fixed by #4696
Assignees
@darkdh
Labels
feature/search QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression settings
Milestone
0.12.5dev

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
If you try to change your search engine preference, nothing happens

Expected behavior:
The orange check box should change as you pick a new default search engine

  • Platform (Win7, 8, 10? macOS? Linux distro?):
  • Brave Version:
    HEAD on master
  • Steps to reproduce:
    1. Open preferences
    2. Go to search
    3. Try to change search engine
  • Screenshot if needed:
  • Any related issues:
    Regression from when multiselect was added
@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 12, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 12, 2016
@darkdh
Do not override handlers of rowAttributes when multiSelect is disabled
f7576e9 
fix brave#4695

Auditors: @bsclifton

Test Plan:
1. Go to about:preferences#search
2. Should be able to change search engine
@darkdh darkdh mentioned this issue Oct 12, 2016
Merged
4 tasks
This was referenced Oct 12, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 13, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/search QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression settings
Projects
None yet
Milestone
0.12.5dev
Development

Successfully merging a pull request may close this issue.

Do not override handlers of rowAttributes when multiSelect is disabled darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv