Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Add multi-select deletion and drag and drop in about:history #3949

Closed
luixxiul opened this issue Sep 13, 2016 · 1 comment · Fixed by #4607
Closed

Add multi-select deletion and drag and drop in about:history #3949

luixxiul opened this issue Sep 13, 2016 · 1 comment · Fixed by #4607

Comments

@luixxiul
Copy link
Contributor

Expected behavior: Please provide ways to delete entries on about:history selectively. For example,

  • checkboxes
  • multiple selection with alt/command key
@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

this is slated for 0.12.3 for @bsclifton

@bsclifton bsclifton self-assigned this Sep 22, 2016
@bsclifton bsclifton modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.4dev Oct 4, 2016
@bbondy bbondy changed the title Add selective deletion on about:history Add multi-select deletion and drag and drop in about:history Oct 4, 2016
darkdh added a commit that referenced this issue Oct 7, 2016
fix #3949

Auditors: @bsclifton, @bbondy

Test Plan:
For click behavior
1. First click should select a entry
2. All the following entries should be selectd with cmd/ctrl + click
3. Another click without cmd/ctrl should cancel selection

For multi selector
1. Open about:history
2. Multi-select entries
3. Test "Open Links in New Tabs"
4. Test "Open Links in New Private Tabs"
5. Test "Open Links in New Session Tabs"
6. Test "Delete History Entries"
darkdh added a commit that referenced this issue Oct 10, 2016
fix #3949

Auditors: @bsclifton, @bbondy

Test Plan:
For click behavior
1. First click should select a entry
2. All the following entries should be selectd with cmd/ctrl + click
3. Another click without cmd/ctrl should cancel selection

1. Click one entry
2. Shift + click another entry in the same table
3. The entry between these two will also be selected

1. Click one entry as start point
2. command/control click other entries between start point and end point in next step
3. Shift + click an entry as end point
4. The entry between start and end point should be selected

Note that range select are not allow across tables

For multi selector
1. Open about:history
2. Multi-select entries
3. Test "Open Links in New Tabs"
4. Test "Open Links in New Private Tabs"
5. Test "Open Links in New Session Tabs"
6. Test "Delete History Entries"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants