Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression : Flash controls are not working #3878

Closed
alexwykoff opened this issue Sep 11, 2016 · 4 comments · Fixed by brave/muon#56
Closed

Regression : Flash controls are not working #3878

alexwykoff opened this issue Sep 11, 2016 · 4 comments · Fixed by brave/muon#56
Assignees
@bridiver @diracdeltas
Labels
plugin/flash QA/checked-Win32 QA/checked-Win64 regression
Milestone
0.12.1dev

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When testing Flash controls in a test run, it was discovered that they are no longer functional.

Expected behavior:
Users should be able to enable Flash when they want.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested Windows 7 ia-32 and OS X
  • Brave Version:
    0.12.1
  • Steps to reproduce:
    1. Visit http://www.y8.com/games/superfighters
    2. Right-click on the flash cover
    3. Observe if the game is ready to play
  • Screenshot if needed:
    flash_player
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.1dev milestone Sep 11, 2016
@alexwykoff alexwykoff mentioned this issue Sep 11, 2016
Closed
78 tasks
@bbondy
Copy link
Member

bbondy commented Sep 12, 2016

@diracdeltas could you take a look?

@bbondy
Copy link
Member

bbondy commented Sep 12, 2016

@bridiver maybe because of the mutation observer removal and replacing with a timer?

@bridiver
Copy link
Collaborator

might be part of it, but I don't think that would cause the permission dialog to do nothing when clicked

@diracdeltas diracdeltas self-assigned this Sep 12, 2016
diracdeltas added a commit that referenced this issue Sep 12, 2016
@diracdeltas
Always hide Flash notification bar after clicked
7f036e9 
Address part of #3878

Auditors: @bbondy

Test Plan:
1. enable flash
2. go to pandora.com, click the 'get flash' button
3. click 'allow' in the flash notification bar
4. observe that the notification bar is gone
@diracdeltas
Copy link
Member

problem appears to be that navigator.mimeTypes and navigators.plugins is now empty regardless of the Flash controls. i.e., if i remove the blockFlash and flashListener content scripts and set the flashActive content setting to 'allow', Flash still doesn't work.

@diracdeltas diracdeltas mentioned this issue Sep 12, 2016
Closed
@bridiver bridiver self-assigned this Sep 13, 2016
bridiver added a commit to brave/muon that referenced this issue Sep 14, 2016
@bridiver
load flash even if the switch is added after AtomContentClient::AddPe…
b18ed58 
…pperPlugins is called

fixes brave/browser-laptop#3878
This was referenced Sep 14, 2016
Merged
Closed
This was referenced Sep 14, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
bridiver added a commit to brave/muon that referenced this issue Sep 17, 2016
@bridiver
load flash even if the switch is added after AtomContentClient::AddPe…
7420773 
…pperPlugins is called

fixes brave/browser-laptop#3878
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

@diracdeltas diracdeltas

Labels
plugin/flash QA/checked-Win32 QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.1dev
Development

Successfully merging a pull request may close this issue.

load flash even if the switch is added after AtomContentClient::AddPe… brave/muon
5 participants
@bridiver @diracdeltas @bbondy @alexwykoff @luixxiul