Zooming in and out don't seem to work when script blocking is on

[silverslimer]

I'm on Facebook at the moment and tried zooming in and out of the page using both the keyboard combination and the options in the menu. Neither have any kind of an effect.

[luixxiul]

@silverslimer Which OS are you using?

[silverslimer]

Hi, Windows 10 64-bit. However, I just tested it now and it seems to work. I guess it was a temporary hiccup.

From: "Suguru Hirahara" [email protected]
To: "brave/browser-laptop" [email protected]
Cc: "silverslimer" [email protected], "Mention" [email protected]
Sent: Thursday, May 12, 2016 8:04:59 PM
Subject: Re: [brave/browser-laptop] Zooming in and out don't seem to work (#1717)

@silverslimer Which OS are you using?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[luixxiul]

There might be a thing which caused it (temp files or like that?), so I
think it is still worth digging.

2016/05/13 9:22 "silverslimer" [email protected]:

Hi, Windows 10 64-bit. However, I just tested it now and it seems to work.
I guess it was a temporary hiccup.

From: "Suguru Hirahara" [email protected]
To: "brave/browser-laptop" [email protected]
Cc: "silverslimer" [email protected], "Mention" [email protected]

Sent: Thursday, May 12, 2016 8:04:59 PM
Subject: Re: [brave/browser-laptop] Zooming in and out don't seem to work
(#1717)

@silverslimer Which OS are you using?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1717 (comment)

[LeMeteore]

I can confirm that on Debian 8.4, zooming works when I click on the buttons inside the menu, but doesn't work using the shortcuts Ctrl-+ / Ctrl--. Not sure if I can help you fix this, but if yes, let me know how please.

[ghost]

Guess the reason why zooming is not working is related to the script blocking function, have used a session file without blocking scripts, and i was able to zoom.

With blocking page scripts, i was unable to use the zoom function. More clearly:

1. If i allow script blocking always on that page, zoom can not be used anymore in most cases
2. If i allow that scripts are blocked only until restart, i can use the zoom function

[bbondy]

I think we need an exact URL. I turned on script blocking and then loaded slashdot.org but I was able to zoom. Also would be useful to know, when you reproduce do context menus work in that tab or is that broken too?

[ghost]

Try out https://vivaldi.net/en-US/forum/vivaldi-browser

Tried also with a totally fresh Brave user profile, as soon as i am using the noscript function on it (not the temporary option) i can not zoom anymore on that page.

Context menu in the tabs do work, only zoom function is totally broken.

Yes, Slashdot works, same like some other pages, but many of my tabs in my normal profile and tabs in the fresh profile are broken zoom function wise.

[bbondy]

I think there must be some other combination of things because I tried that link with script blocking on and zoom is still working.

[bbondy]

Zooming with both Command+Plus and Command+Minus on OS X. Also with hamburger menu. 0.9.6.

[ghost]

Using Windows 8.1 here. Windows only bug perhaps? Anyway, i can reproduce that problem in both my normal profile and a totally fresh one.

[Arandhras]

I can confirm I also that I have this issue with https://vivaldi.net/en-US/forum/vivaldi-browser .
WIndows 10 x64, version 0.9.6, x64 build.

[bbondy]

@Arandhras also only when script blocking?

[Arandhras]

@bbondy Yes, that is correct.

[bbondy]

Can you guys check for an error in console?
Control+Alt+J for the browser level console.

[ghost]

Not seeing anything

[bbondy]

How about in the content dev tools Control+Alt+I (popup window devtools)

[ghost]

There i see some error messages. But i really do not know if they have to do something with this problem, anyway, still posting:

(WEB_PAGE context) extensions::ipc_utils:35: Uncaught TypeError: Error processing argument at index 0, conversion failure from null{TypeError: Error processing argument at index 0, conversion failure from null
at TypeError (native)
at EventEmitter2. (extensions::ipc_utils:35:22)
at EventEmitter2.emit (extensions::event_emitter:43:20)
at EventEmitter2.ipcRenderer.emit (extensions::ipc_utils:31:40)}

[bbondy]

cc @bridiver since it looks like an error in extensions::ipc_util.