Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Right click on tab does not display context menu #12345

Closed
LaurenWags opened this issue Dec 20, 2017 · 7 comments · Fixed by #12351
Closed

Right click on tab does not display context menu #12345

LaurenWags opened this issue Dec 20, 2017 · 7 comments · Fixed by #12351

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 20, 2017

Test plan

#12351 (comment)


Description

Right click on a tab does not produce the context menu.

Steps to Reproduce

  1. Clean profile using 0.20.8
  2. Open a tab, right click on tab.

Actual result:
No context menu is displayed.

@kjozwiak saw this error in terminal: [51634:775:1220/162016.991127:ERROR:CONSOLE(12)] "Uncaught TypeError: Cannot read property 'size' of undefined", source: chrome://brave/Applications/Brave-Beta.app/Contents/Resources/app.asar/app/extensions/brave/gen/app.entry.js (12)

Expected result:
Context menu should be displayed, no error in terminal.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.8
V8 | 6.3.292.48
rev | 015a3db
Muon | 4.5.28

Reproducible on current live release:
no

Additional Information

  • Was working with 0.20.3, stopped working with 0.20.5
  • Reproducible with MacOS and Windows (@srirambv and @kjozwiak ) (Linux is unavailable atm)
  • The following steps can act as a workaround for getting the context menu to display:
  1. Detatch a tab from window with multiple tabs
  2. Reattach the tab
  3. Right click on tab and context menu will work
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Dec 20, 2017
@diracdeltas diracdeltas self-assigned this Dec 20, 2017
diracdeltas added a commit that referenced this issue Dec 20, 2017
Fix #12345

Test Plan:
1. open brave
2. right-click on a tab
3. the context menu should appear and 'Re-open last closed tab' menu item should be disabled
4. open a new tab, go to any website. close the tab
5. repeat step 3. now the menu item should be enabled.
@chaseleslie
Copy link

This appears to be a duplicate of issue #12203 . I suppose one or the other should be closed?

@bsclifton
Copy link
Member

bsclifton commented Dec 21, 2017

@sharmalay thanks for the heads up! 😄 I'll pull your issue into our next release.

@LaurenWags can you confirm this is a dupe? (if so, maybe we can close this in favor of the one @sharmalay is working on, #12203)

@NejcZdovc
Copy link
Contributor

@bsclifton @sharmalay from the fix that @diracdeltas did it's a different issue.

@diracdeltas
Copy link
Member

it looks like the same issue to me

@diracdeltas
Copy link
Member

@bsclifton i already opened a PR for this issue

@srirambv
Copy link
Collaborator

Error looks similar but its different. Here's the screengrab from Windows
tab-context

@diracdeltas
Copy link
Member

@srirambv it will show app.entry.js instead of the pre-minified filename if you're using a packaged build. so i think it's a duplicate as mentioned in #12203 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.