Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import cookie from Chrome hangs on linux #11280

Closed
darkdh opened this issue Oct 4, 2017 · 3 comments · Fixed by brave/muon#333 or brave/muon#340
Closed

Import cookie from Chrome hangs on linux #11280

darkdh opened this issue Oct 4, 2017 · 3 comments · Fixed by brave/muon#333 or brave/muon#340
Assignees
@darkdh
Labels
bug feature/importer muon OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@darkdh
Copy link
Member

darkdh commented Oct 4, 2017 •
edited by kjozwiak
Loading

Importing cookies from either Chrome/Chromium on linux will hang and produce a crash. However, the crash doesn't take down the entire browser.

Steps to Reproduce

  1. using a linux distro, ensure that you have either Chrome/Chromium installed
  2. install and launch Brave
  3. visit about:preferences#general and click on "Import Now.."
  4. select "Chrome" from the dropdown list and ensure "Cookies" is the only option selected
  5. click on "Import" and you'll receive the crash (see examples listed below)

Reproduces how often: [What percentage of the time does it reproduce?]

100% reproducible using the above STR.

Brave Version

Brave: 0.19.28
rev: 08781a5
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100

Reproducible on current live release:

0.18.36 isn't crashing when importing cookies from Chrome/Chromium, but it looks like it's not working either... Example:

You'll notice that the cookie information from Chrome/Chromium hasn't been imported.

Examples of Issue:

31145045-8d2f0106-a850-11e7-8114-e5bd72a20a6c

31145048-8fb3c9de-a850-11e7-9a92-1db3c410df89

31145070-a709d52e-a850-11e7-9133-4af06c561022

Additional Information

cc @kjozwiak
@darkdh darkdh added this to the 0.19.x (Beta Channel) milestone Oct 4, 2017
@darkdh darkdh self-assigned this Oct 4, 2017
@kjozwiak kjozwiak mentioned this issue Oct 5, 2017
Closed
darkdh added a commit to brave/muon that referenced this issue Oct 7, 2017
@darkdh
Fix OSCrypt::DecryptString crash by preventing null config getting
6bce9d5 
when import encrypted cookie value from Chrome on Linux

fix brave/browser-laptop#11280

Auditors: @bridiver, @bbondy, @bsclifton
@darkdh darkdh mentioned this issue Oct 7, 2017
Merged
@bsclifton
Copy link
Member

Moving to 0.19.x release 2

@bsclifton bsclifton modified the milestones: 0.19.x (Beta Channel), 0.19.x Release 2 (Beta Channel) Oct 10, 2017
@bsclifton bsclifton modified the milestones: 0.19.x Release 2 (Beta Channel), 0.19.x (Beta Channel) Oct 10, 2017
@bsclifton
Copy link
Member

Moving back to 0.19.x- Muon build is in progress (should be in one of the next 0.19.x builds)

@kjozwiak
Copy link
Member

kjozwiak commented Oct 11, 2017 •
edited
Loading

@darkdh it looks like this is still happening under Ubuntu... I went through the same STR that are listed under #11280 (comment) and received the crash reporter once I tried importing cookies from Chrome... @srirambv also tried on his Ubuntu VM and could also reproduce the issue.

Platforms used:

  • Ubuntu 17.04 x64 - Reproduced (still failing and tested on two VM's)
  • Ubuntu 16.04 x64 - Reproduced (still failing and tested on a VM/Desktop)

Brave being used:

Brave: 0.19.41
rev: c33d1c3
Muon: 4.4.27
libchromiumcontent: 61.0.3163.100

I'm not sure that we're going to have enough time to get this fixed by tomorrow.... If not, we can move it out and place it into https://github.com/brave/browser-laptop/milestone/84.

@kjozwiak kjozwiak reopened this Oct 11, 2017
darkdh added a commit to brave/muon that referenced this issue Oct 11, 2017
@darkdh
Don't call OSCrypt::IsEncryptionAvailable which will directly get pas…
93c25d0 
…sword before SetConfig()

fix brave/browser-laptop#11280 again

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue Oct 11, 2017
Merged
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/importer muon OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
4 participants
@kjozwiak @luixxiul @bsclifton @darkdh