Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Description for Session Tab on Hover #10464

Closed
eljuno opened this issue Aug 13, 2017 · 2 comments · Fixed by #10691
Closed

Description for Session Tab on Hover #10464

eljuno opened this issue Aug 13, 2017 · 2 comments · Fixed by #10691

Comments

@eljuno
Copy link
Contributor

eljuno commented Aug 13, 2017

Test plan

#10691 (comment)


  • Did you search for similar issues before submitting this one?
    No.

  • Describe the issue you encountered:
    Description tooltip when hovering on session tab have tofu and description not show properly.
    See screenshot and record for better explanation.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win 8.1

  • Brave Version (revision SHA):
    0.18.14 (ad92d02)

  • Steps to reproduce:

    1. Set to 20 tab per tab set on about:preferences#tabs
    2. Create session tab,
    3. Hover to "person icon"
  • Actual result:
    See screenshot

  • Expected result:
    description show correctly like this one (from clicking lock icon on URL bar)
    image

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    brave-session-tab-description

brave-session-tab-description

  • Any related issues:
@cndouglas
Copy link

Looks like the variable partitionNumber is not being substituted properly either.

Also, that tooltip is not shown unless the tabs are small enough to hide the close button. Might be a usability problem.

@cezaraugusto cezaraugusto self-assigned this Sep 14, 2017
@cezaraugusto cezaraugusto added this to the 0.20.x (Developer Channel) milestone Sep 14, 2017
@cezaraugusto
Copy link
Contributor

setting to sprint/1 and tagging for 0.20.x as this will be fixed by #10691 cc @zentagonist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.