Devtool via context menu cannot be displayed

[luixxiul]

Test plan

#10660 (comment)

---

Describe the issue you encountered: devtool via context menu cannot be displayed due to this error:

[26861:775:0802/182721.667654:ERROR:CONSOLE(0)] "(WEBUI context) http://localhost:8080/gen/app.entry.js:52874: Uncaught TypeError: webview.inspectElement is not a function{TypeError: webview.inspectElement is not a function
    at Object.inspectElement (http://localhost:8080/gen/app.entry.js:52874:16)
    at click (http://localhost:8080/gen/app.entry.js:73957:25)
    at CallbacksRegistry.apply (extensions::callbacks-registry:61:39)
    at EventEmitter.<anonymous> (extensions::remote:284:21)
    at emitThree (extensions::event_emitter:115:13)
    at EventEmitter.emit (extensions::event_emitter:196:7)
    at EventEmitter.ipcRenderer.emit (extensions::ipc_utils:31:22)}", source: chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index-dev.html (0)

It can be displayed via menubar.

• Platform (Win7, 8, 10? macOS? Linux distro?): macOS

• Brave Version (revision SHA): master branch

• Steps to reproduce:

  1. Open context menu
  2. Click Inspect Element

• Actual result: nothing happens

• Expected result: devtool should be displayed

• Extra QA steps:
  1.
  2.
  3.

• Any related issues:

[jonathansampson]

+1 This is pretty important.

[alexwykoff]

if we could have a regression range check on this that'd be great

[luixxiul]

The devtool is displayed via the context menu on:

Brave: 0.18.23
rev: 36ae2ec
Muon: 4.3.10
libchromiumcontent: 60.0.3112.90
V8: 6.0.286.52
Node.js: 7.9.0
Update Channel: dev
OS Platform: Linux
OS Release: 4.9.0-3-amd64
OS Architecture: x64

[luixxiul]

escalating the milestone for QA

[bsclifton]

Moving to 0.19.x because this doesn't happen on 0.18.x (tested on Windows and macOS using 0.18.23). If issue isn't present in 0.19.x, let's push back to 0.20.x and test

[kjozwiak]

I managed to reproduce the issue with the 0.19.x branch and found the regression range using git bisect:

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[386b34d] Update Muon to 4.4.0

It appears that the update to muon 4.4.0 is causing the regression. Anything before the muon 4.4.0 update works without any issues.

@bridiver could you please take a look?

I received the same results as @bsclifton while testing the 0.18.x branch. I couldn't reproduce the issue using both macOS 10.12.6 x64 and Win 10 x64.

• Brave 0.18.14 rev ad92d02 - couldn't reproduce the issue
• Brave 0.18.15 rev 2ca81b8 - couldn't reproduce the issue
• Brave 0.18.17 rev ed66917 - couldn't reproduce the issue
• Brave 0.18.18 rev f3f5cc6 - couldn't reproduce the issue
• Brave 0.18.19 rev 66c3027 - couldn't reproduce the issue
• Brave 0.18.20 rev 60bb9e6 - couldn't reproduce the issue
• Brave 0.18.21 rev 263b6d5 - couldn't reproduce the issue
• Brave 0.18.22 rev d850e28 - couldn't reproduce the issue
• Brave 0.18.23 rev 36ae2ec - couldn't reproduce the issue

[bridiver]

webview.inspectElement no longer exists. webviewActions.inspectElement(nodeProps.x, nodeProps.y) should be converted to an appAction that passes tabId, x, y to call inspectElement on the webContents along with everything else in webviewActions. webview methods are deprecated in general and we should be converting them to actions that run on the browser process

[bridiver]

inspectElement was removed because I didn't notice the usage when I was searching for webview methods, but at this point a browser-laptop fix is faster and better and @NejcZdovc already has one