Fix JavaScript crash which I have seen happen with 0.17.13

Auditors: @NejcZdovc
brave · Jul 3, 2017 · 97adc1e · 97adc1e
1 parent 70f499e
commit 97adc1e
Showing 1 changed file with 29 additions and 27 deletions.
diff --git a/app/common/lib/suggestion.js b/app/common/lib/suggestion.js
@@ -646,33 +646,35 @@ const filterSuggestionListByType = (suggestionList) => {
   const searchSuggestions = []
   const topSiteSuggestions = []
 
-  suggestionList.forEach(item => {
-    switch (item.get('type')) {
-      case suggestionTypes.BOOKMARK:
-        bookmarkSuggestions.push(item)
-        break
-
-      case suggestionTypes.HISTORY:
-        historySuggestions.push(item)
-        break
-
-      case suggestionTypes.ABOUT_PAGES:
-        aboutPagesSuggestions.push(item)
-        break
-
-      case suggestionTypes.TAB:
-        tabSuggestions.push(item)
-        break
-
-      case suggestionTypes.SEARCH:
-        searchSuggestions.push(item)
-        break
-
-      case suggestionTypes.TOP_SITE:
-        topSiteSuggestions.push(item)
-        break
-    }
-  })
+  if (suggestionList) {
+    suggestionList.forEach(item => {
+      switch (item.get('type')) {
+        case suggestionTypes.BOOKMARK:
+          bookmarkSuggestions.push(item)
+          break
+
+        case suggestionTypes.HISTORY:
+          historySuggestions.push(item)
+          break
+
+        case suggestionTypes.ABOUT_PAGES:
+          aboutPagesSuggestions.push(item)
+          break
+
+        case suggestionTypes.TAB:
+          tabSuggestions.push(item)
+          break
+
+        case suggestionTypes.SEARCH:
+          searchSuggestions.push(item)
+          break
+
+        case suggestionTypes.TOP_SITE:
+          topSiteSuggestions.push(item)
+          break
+      }
+    })
+  }
 
   return {
     bookmarkSuggestions,