Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Return null redirectURL for HTTPS Everywhere excluded URLs
Browse files Browse the repository at this point in the history
When redirectURL is set to the original URL, this can cause the browser to throw
net::ERR_TOO_MANY_REDIRECTS and not load the URL. Caused foxnews.com to break.

Auditors: @bbondy
  • Loading branch information
diracdeltas committed Feb 24, 2016
1 parent 2e6c8e6 commit 8a34b77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/httpsEverywhere.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function applyRuleset (url, applicableRule) {
for (i = 0; i < exclusion.length; ++i) {
exclusionPattern = new RegExp(exclusion[i].$.pattern)
if (exclusionPattern.test(url)) {
return url
return null
}
}
}
Expand Down

1 comment on commit 8a34b77

@bbondy
Copy link
Member

@bbondy bbondy commented on 8a34b77 Feb 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.