Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Closed frames shouldn't include newtab
Browse files Browse the repository at this point in the history
Fix #3258

Auditors: @bbondy

Test Plan: New Tab, close it, look in History menu to ensure it's not among recently closed
  • Loading branch information
BrendanEich committed Sep 8, 2016
1 parent 0a2141f commit 56e9ecc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/state/frameStateUtil.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ function removeFrame (frames, tabs, closedFrames, frameProps, activeFrameKey) {
0)
}

if (!frameProps.get('isPrivate')) {
if (!frameProps.get('isPrivate') && frameProps.get('location') !== 'about:newtab') {
frameProps = frameProps.set('isFullScreen', false)
closedFrames = closedFrames.push(frameProps)
if (frameProps.get('thumbnailBlob')) {
Expand Down

0 comments on commit 56e9ecc

Please sign in to comment.