Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add issue/PR templates
Browse files Browse the repository at this point in the history
  • Loading branch information
@diracdeltas
diracdeltas committed May 16, 2016
1 parent 1f759b1 commit 085b7bb
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
0 CONTRIBUTING.md → .github/CONTRIBUTING.md
View file
File renamed without changes.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- [ ] Did you search for similar issues before submitting this one?

This comment has been minimized.

Sign in to view

Copy link
@luixxiul

luixxiul May 17, 2016

Contributor

Based on #1748 (comment),

:heavy_check_mark: I have searched for similar issues before submitting this one.

This comment has been minimized.

Sign in to view

Copy link
@diracdeltas

diracdeltas May 18, 2016

Author Member

Might be confusing to users who don't know markdown

This comment has been minimized.

Sign in to view

Copy link
@luixxiul

luixxiul May 18, 2016

Contributor

OK then let's remove both and leave a statement according to #1748 (comment):

I have searched for similar issues before submitting this one.

- Describe the issue you encountered:
- Expected behavior:

- Platform
- Win7, 8, 10? OS X? Linux(distro)?
- Brave Version
- Steps to reproduce
1.
2.
3.
- Screenshot (if needed)
- # of any related issues
3 changes: 3 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- [ ] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.
- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.
- [ ] Ran `git rebase -i` to squash commits if needed.

2 comments on commit 085b7bb

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented on 085b7bb May 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the issue #1788 based on the template, and noticed this would be better.

:heavy_check_mark: I have searched for similar issues before submitting this one.

**Describe the issue you encountered:** ...

**Expected behavior:** ...

- Platform: ...
- Brave Version: ...

How do you think, @diracdeltas ?

@neeklamy
Copy link
Contributor

@neeklamy neeklamy commented on 085b7bb Jun 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including a prompt before that? It might also make it more clear that it’s to be edited and show how it’s edited:

I have (please tick where appropriate [x])

  • Submitted a ticket for my issue if one did not already exist.
  • Used GitHub auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

One other thing, sometimes the CI builds are initiated for simple typos or changing the documentation (three of the most recent document change only builds: one, two, three). These unnecessary builds are taking upwards of 40 minutes a time. Perhaps include a line about very minor edits too:

Is this a minor edit (for example, a change to README.md)?
Please include the [ci skip] tag in the subject.

Please sign in to comment.