Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start_date/end_date support. #605

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add start_date/end_date support. #605

merged 1 commit into from
Apr 18, 2023

Conversation

goodov
Copy link
Member

@goodov goodov commented Apr 18, 2023

@goodov goodov requested a review from tmancey April 18, 2023 14:10
tmancey
tmancey approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodov goodov merged commit 201ba45 into main Apr 18, 2023
@goodov goodov deleted the issues/29810 branch April 18, 2023 14:28
@goodov goodov mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start_date and end_date in variation seed is not respected
2 participants
@goodov @tmancey