Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating most performant test leg of ad model predictor recency study #1115

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ptjames
Copy link
Contributor

@ptjames ptjames commented Jul 8, 2024

Updating most performant test leg of ad model predictor recency study to 100% until brave-core changes reach production.

Issue: #1114
Changes become permanent in brave-core via this PR: brave/brave-core#24253

… to 100% until brave-core changes reach production
@ptjames ptjames requested review from tmancey and aseren July 8, 2024 15:55
@ptjames ptjames marked this pull request as ready for review July 8, 2024 15:57
@ptjames ptjames requested a review from a team as a code owner July 8, 2024 15:57
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved 👍 As discussed via https://bravesoftware.slack.com/archives/C01LKMP6X36/p1720454503659199, we're just increasing the % so there's nothing that QA needs to really do in terms of verification. Has been previously checked via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1716481614558189. This will also be enabled 100% by default once brave/brave-core#24253 makes it into production.

@kjozwiak kjozwiak merged commit 9821038 into production Jul 10, 2024
3 checks passed
@kjozwiak kjozwiak deleted the ad_model_recency_study_completed_prod branch July 10, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants