Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Add Text component #587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Text component #587

wants to merge 4 commits into from

Conversation

kayun
Copy link

@kayun kayun commented May 5, 2021

Changes

Add a text component #118

  • rename src/components/text to src/components/typography
  • add Text component
  • add unit-tests
  • add storybook page

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant