Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Missing text changes for JP region #1765

Closed
kylehickinson opened this issue Oct 22, 2019 · 5 comments
Closed

Missing text changes for JP region #1765

kylehickinson opened this issue Oct 22, 2019 · 5 comments
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@kylehickinson
Copy link
Collaborator

  • "Grants" -> "Details" on wallet header
  • "Your wallet" -> "Your balance" in wallet header
  • "wallet balance" -> "balance" in tipping view
@kylehickinson kylehickinson self-assigned this Oct 22, 2019
kylehickinson added a commit that referenced this issue Oct 22, 2019
@kylehickinson
Fix #1765: Adds missing JP rewards UI updates
5bb747a 
- "Grants" -> "Details" on wallet header
- "Your wallet" -> "Your balance" in wallet header
- "wallet balance" -> "balance" in tipping view
@kylehickinson kylehickinson mentioned this issue Oct 22, 2019
Merged
7 tasks
@kylehickinson kylehickinson added this to the 1.13 milestone Oct 22, 2019
@anthonypkeane
Copy link

Text Update:
On onboarding, for Japan, change tokens to points

@kylehickinson
Copy link
Collaborator Author

Auto-contribute wallet notification "BAT" → "BAT Points"

kylehickinson added a commit that referenced this issue Oct 23, 2019
@kylehickinson
Fix #1765, Fix #1744: Adds missing JP rewards UI updates
8282090 
- "Grants" -> "Details" on wallet header
- "Your wallet" -> "Your balance" in wallet header
- "wallet balance" -> "balance" in tipping view
- "tokens" -> "points"
kylehickinson added a commit that referenced this issue Oct 23, 2019
@kylehickinson
Fix #1765, Fix #1744: Adds missing JP rewards UI updates
0e1df30 
- "Grants" -> "Details" on wallet header
- "Your wallet" -> "Your balance" in wallet header
- "wallet balance" -> "balance" in tipping view
- "tokens" -> "points"
@kylehickinson
Copy link
Collaborator Author

Monthly payment AC/recurring tip screens: "BAT" → "BAT Points"

kylehickinson added a commit that referenced this issue Oct 23, 2019
@kylehickinson
Fix #1765, Fix #1744: Adds missing JP rewards UI updates
5d55200 
- "Grants" -> "Details" on wallet header
- "Your wallet" -> "Your balance" in wallet header
- "wallet balance" -> "balance" in tipping view
- "tokens" -> "points"
- "BAT" -> "BAT Points" where missed
@srirambv
Copy link
Contributor

Blocked on #1656

This was referenced Oct 31, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Nov 4, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.11.4.14)

  • Verified Grants is replaced with View Details
    image
  • Verified Your wallet is replaced with Your balance
    image
  • Verified Wallet balance is replaced with Balance
    image

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.11.4.14)

  • Verified Grants is replaced with View Details
  • Verified Your wallet is replaced with Your balance
  • Verified Wallet balance is replaced with Balance

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.11.4.14)

  • Verified Grants is replaced with View Details
  • Verified Your wallet is replaced with Your balance
  • Verified Wallet balance is replaced with Balance

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.11.4.14)

  • Verified Grants is replaced with View Details
    image
  • Verified Your wallet is replaced with Your balance
    image
  • Verified Wallet balance is replaced with Balance
    image

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.11.4.14)

  • Verified Grants is replaced with View Details
    image
  • Verified Your wallet is replaced with Your balance
    image
  • Verified Wallet balance is replaced with Balance
    image

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kylehickinson @anthonypkeane @srirambv