Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure loaded PDFs are not 3P to themselves for blocking consideration #967

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Make sure loaded PDFs are not 3P to themselves for blocking consideration #967

merged 2 commits into from
Nov 28, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Nov 27, 2018

Fix brave/brave-browser#1033

The first commit fixes what is described.
The second commit fixes a failing PDFJS test which is on master.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

emerick
emerick approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diracdeltas
diracdeltas approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbondy bbondy merged commit 86cf2d3 into master Nov 28, 2018
bbondy added a commit that referenced this pull request Nov 28, 2018
@bbondy
Merge pull request #967 from brave/pdfjs-blocking-2
830f015 
Make sure loaded PDFs are not 3P to themselves for blocking consideration
@bbondy
Copy link
Member Author

bbondy commented Nov 28, 2018

master: 86cf2d3
0.58.x: 830f015

@kjozwiak kjozwiak deleted the pdfjs-blocking-2 branch November 28, 2018 06:04
@kjozwiak
Copy link
Member

Approved uplift to 0.57.x after deliberating with @srirambv & @rebron 👍

bbondy added a commit that referenced this pull request Nov 28, 2018
@bbondy
Merge pull request #967 from brave/pdfjs-blocking-2
c72b837 
Make sure loaded PDFs are not 3P to themselves for blocking consideration
@bbondy
Copy link
Member Author

bbondy commented Nov 28, 2018

0.57.x: c72b837

@bsclifton bsclifton mentioned this pull request Jan 3, 2019
Closed
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
@btlechowski btlechowski mentioned this pull request Aug 7, 2020
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@diracdeltas diracdeltas diracdeltas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.57.x - Release
Development

Successfully merging this pull request may close these issues.

Some PDFs don't open
4 participants
@bbondy @kjozwiak @diracdeltas @emerick