-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Brave ads database migration from schema 10 #9589
Conversation
vendor/bat-native-ads/src/bat/ads/internal/database/database_table_util.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/database/tables/conversion_queue_database_table.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/database/tables/conversions_database_table.cc
Show resolved
Hide resolved
80bfecd
to
d97c69f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a61a54e
to
5744d3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4aea37e
to
20f6aaa
Compare
ef0abb9
to
e363f6d
Compare
Verification PASSED on
Upgraded from Ensured that
Ensured that both
Ensured that website classification is working after upgrading as per the following:
Ensured that ad notifications are working as per the following:
Moved the date ~3 days ahead and ensured that Brave successfully redeemed the unblinded payment tokens as per the following:
Also ensured that:
|
Resolves brave/brave-browser#17231
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#17231