Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved settings menu styles according to figma #9301

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 1, 2021

Resolves brave/brave-browser#16111

image

2021-07-01_19h03_50

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave://ipfs settings page
  • Check menu styles according to figma

@spylogsster spylogsster merged commit 99edf90 into master Jul 2, 2021
@spylogsster spylogsster deleted the issue-16111 branch July 2, 2021 07:25
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 2, 2021
@karenkliu
Copy link

@AlanBreck @petemill Can you take a look at this focus state that's causing the UI element to shift? I thought we were able to implement our focus states in a way that wouldn't cause UI elements to move around.

@AlanBreck
Copy link
Collaborator

It's because border is being used instead of border-shadow or outline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Little indication of IPFS tab selected in settings
4 participants