Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial Rewards state migration for old versions #9143

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jun 15, 2021

Resolves brave/brave-browser#16449

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario: Reading from legacy JSON files on upgrade from old version

  • Given that the user profile directory contains ledger_state and publisher_state JSON files
  • And the brave.rewards.version profile preference does not exist
  • When the user restarts the browser
  • Then the user's Rewards wallet information should be imported from the ledger_state file

Possible test steps

  • Start the browser with a clean profile to create a profile directory.
  • Close the browser.
  • Copy ledger_state and publisher_state JSON files into the profile directory.
  • Start the browser.
  • Navigate to brave://rewards-internals.
  • Verify that the displayed payment ID matches the payment ID from the ledger_state file.

@zenparsing zenparsing requested a review from a team as a code owner June 15, 2021 16:59
@zenparsing
Copy link
Collaborator Author

Putting this back into draft, as it causes issues with first-time startup.

@zenparsing zenparsing marked this pull request as draft June 15, 2021 17:31
@zenparsing zenparsing force-pushed the ksmith-initial-state-migration branch from 2d2878a to 68fb741 Compare June 15, 2021 18:36
@zenparsing zenparsing marked this pull request as ready for review June 15, 2021 19:49
@zenparsing zenparsing force-pushed the ksmith-initial-state-migration branch from 68fb741 to 63096fc Compare June 23, 2021 19:35
@zenparsing zenparsing force-pushed the ksmith-initial-state-migration branch from 63096fc to 748b278 Compare June 25, 2021 18:17
@zenparsing zenparsing requested review from emerick and removed request for kylehickinson June 25, 2021 18:18
@zenparsing zenparsing force-pushed the ksmith-initial-state-migration branch from 748b278 to bd7a8fe Compare June 28, 2021 15:20
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 3361d85 into master Jun 29, 2021
@zenparsing zenparsing deleted the ksmith-initial-state-migration branch June 29, 2021 14:08
@zenparsing zenparsing added this to the 1.28.x - Nightly milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards wallet is reset on upgrade from very old version
2 participants