Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes follow up of #13038 - swiping up ad notification doesn't trigger the dismiss event type #9099

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 11, 2021

Resolves brave/brave-browser#16361

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#16361

@tmancey tmancey requested a review from yachtcaptain23 June 11, 2021 15:41
@tmancey tmancey self-assigned this Jun 11, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 16, 2021

Verification passed on Samsung Galaxy Tab version 10 running Nightly Bravemonoarm64_1.27.66apk
Verified the STR from brave/brave-browser#16361 (comment)

Confirmed swiping up custom ad notification triggers the dismiss event type

 2021-06-16 12:16:26.767 303-303/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
      URL: https://ads-serve.brave.com/v1/confirmation/365cb137-eaea-4b11-af4a-717dfa61ee5e/paymentToken
      Response Status Code: 200
      Response: {"id":"365cb137-eaea-4b11-af4a-717dfa61ee5e","createdAt":"2021-06-16T06:46:23.810Z","type":"dismiss","modifiedAt":"2021-06-16T06:46:23.820Z","creativeInstanceId":"c5698446-a303-451c-a977-b2ecfb542604","paymentToken":{"publicKey":"uor3AzFj4OmdCxwetsYD1TxPXZSw40t3j/VOCUyC7Rs=","batchProof":"6WDAjjxbmsJXVbc0uQGyYd9fNgbPels+KeGIMMjNzQQHfBYeDlrhYvTVf9sVHnOdF5bgLqBQ037tRqhqq9PSCw==","signedTokens":["KoAOdYyoxqkfZWlEGMUaE2lNwl5FPI5eohd9XC6tjlc="]}}
2021-06-16 12:16:26.805 303-303/? V/chromium: [VERBOSE1:confirmations.cc(252)] Successfully redeemed unblinded token with confirmation id 365cb137-eaea-4b11-af4a-717dfa61ee5e, creative instance id c5698446-a303-451c-a977-b2ecfb542604 and dismiss
2021-06-16 12:16:26.807 303-303/? V/chromium: [VERBOSE1:confirmations.cc(275)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 3 unblinded payment tokens

####Additional testing
Confirmed Custom ad notifications are served
Confirmed View/Click/Landed events are captured correctly
Confirmed ad notification is auto-dismissed after 30 secs
Confirmed clicking on the ad notification loads the landing page in a NTP
Confirmed users are rewarded for viewing custom ads

View:

2021-06-16 12:03:12.856 303-303/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
      URL: https://ads-serve.brave.com/v1/confirmation/dfb71967-ad87-4769-b4dd-8043b1466f3b/paymentToken
      Response Status Code: 200
      Response: {"id":"dfb71967-ad87-4769-b4dd-8043b1466f3b","createdAt":"2021-06-16T06:33:10.363Z","type":"view","modifiedAt":"2021-06-16T06:33:10.371Z","creativeInstanceId":"0d342e2f-0f41-46d5-a8c1-e74ff6b65da7","paymentToken":{"publicKey":"oOJO/xLaCXGW6yhpeIfM4K1X2ln7sgdjTCTCHe8BugE=","batchProof":"CZnlUoAv4NYKSBl1yDrbYF7g9uxCxAArfxP23Bb+PQ4TjedhheiHYmcLXGoYp2o7TKcfGnStFdpipGq4nfs2Dw==","signedTokens":["sOS8e96xcMcsAdWnQQpczKd4AQjLeZ01M5eoMfdjnDQ="]}}
2021-06-16 12:03:12.870 303-303/? V/chromium: [VERBOSE1:confirmations.cc(252)] Successfully redeemed unblinded token with confirmation id dfb71967-ad87-4769-b4dd-8043b1466f3b, creative instance id 0d342e2f-0f41-46d5-a8c1-e74ff6b65da7 and view
2021-06-16 12:03:12.872 303-303/? V/chromium: [VERBOSE1:confirmations.cc(275)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Click:

2021-06-16 12:28:24.179 303-303/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
      URL: https://ads-serve.brave.com/v1/confirmation/b9cf5292-89de-4ed9-90e6-73c016e53b38/paymentToken
      Response Status Code: 200
      Response: {"id":"b9cf5292-89de-4ed9-90e6-73c016e53b38","createdAt":"2021-06-16T06:58:23.442Z","type":"click","modifiedAt":"2021-06-16T06:58:23.449Z","creativeInstanceId":"0210de7e-2a7a-4ba7-af73-960acaac63fe","paymentToken":{"publicKey":"uor3AzFj4OmdCxwetsYD1TxPXZSw40t3j/VOCUyC7Rs=","batchProof":"j3Dc85ddZv30/arBuPsBmpUOmylgti+4TPSW/PpcLQzs+ux/MhJvhsB80bfJFxHMOJq9s+jGMN3j0l/j+uT7Bw==","signedTokens":["sGhHD3Q6dwUZbdxZnm04g8zyPsr+nmHfqvC24j44838="]}}
2021-06-16 12:28:24.188 303-303/? V/chromium: [VERBOSE1:confirmations.cc(252)] Successfully redeemed unblinded token with confirmation id b9cf5292-89de-4ed9-90e6-73c016e53b38, creative instance id 0210de7e-2a7a-4ba7-af73-960acaac63fe and click
2021-06-16 12:28:24.190 303-303/? V/chromium: [VERBOSE1:confirmations.cc(275)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 5 unblinded payment tokens

Landed:

2021-06-16 12:28:39.143 303-303/? V/chromium: [VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
      URL: https://ads-serve.brave.com/v1/confirmation/d908974f-270c-429c-b7e1-1db420a6af5d/paymentToken
      Response Status Code: 200
      Response: {"id":"d908974f-270c-429c-b7e1-1db420a6af5d","createdAt":"2021-06-16T06:58:38.194Z","type":"landed","modifiedAt":"2021-06-16T06:58:38.200Z","creativeInstanceId":"0210de7e-2a7a-4ba7-af73-960acaac63fe","paymentToken":{"publicKey":"uor3AzFj4OmdCxwetsYD1TxPXZSw40t3j/VOCUyC7Rs=","batchProof":"MOMXNs0w2PjV19gUgXNwJGUM0GMFosD292uIMhTsng3jCRMy0sJoqoc5QPB8uyIPFLkUo67BemzMEoazcKeLDA==","signedTokens":["SM1W0PpttIP5zuL/B1DKk58bZRqmbngMsPFaJbaeq2I="]}}
2021-06-16 12:28:39.162 303-303/? V/chromium: [VERBOSE1:confirmations.cc(252)] Successfully redeemed unblinded token with confirmation id d908974f-270c-429c-b7e1-1db420a6af5d, creative instance id 0210de7e-2a7a-4ba7-af73-960acaac63fe and landed
2021-06-16 12:28:39.164 303-303/? V/chromium: [VERBOSE1:confirmations.cc(275)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 6 unblinded payment tokens

Timeout:

2021-06-16 12:28:19.574 303-303/? V/chromium: [VERBOSE1:ads_service_impl.cc(1888)] Timeout ad notification with uuid 6f5cccb9-8a47-413b-ade5-0dc6f80643ce in 30 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up of #13038 - swiping up ad notification doesn't trigger the dismiss event type
3 participants