Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IPFS_LOCAL_NODE_ENABLED to separate local node deps #9058

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 9, 2021

Resolves brave/brave-browser#16267

  • Added IPFS_LOCAL_NODE_ENABLED to separate local node deps

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Full regression of IPFS for Desktop/Mobile

@spylogsster spylogsster marked this pull request as draft June 9, 2021 12:00
@spylogsster spylogsster changed the base branch from master to remove-context-from-network-utils June 9, 2021 12:01
@spylogsster spylogsster removed the request for review from kylehickinson June 9, 2021 12:01
@spylogsster spylogsster changed the title do not merge Added IPFS_LOCAL_NODE_ENABLED to separate local node deps Jun 9, 2021
@spylogsster spylogsster marked this pull request as ready for review June 9, 2021 13:47
@spylogsster spylogsster requested a review from bbondy June 9, 2021 15:27
Base automatically changed from remove-context-from-network-utils to master June 9, 2021 17:11
@spylogsster spylogsster merged commit 5a4a600 into master Jun 10, 2021
@spylogsster spylogsster deleted the ios-build branch June 10, 2021 05:10
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable local node for iOS
3 participants