Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add l10n support of resolve method options in decentralized DNS settings #8317

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 22, 2021

Resolves brave/brave-browser#14862
Resolves brave/brave-browser#14864

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. in brave/settings/extenstions, set resolve method of Unstoppable Domains to Ask, visit brave.crypto, should see interstitial page to opt-in.
  2. Change settings to Disabled in settings, and refresh brave.crypto page, should see error page.
  3. Change settings to DNS over HTTPS in settings, and refresh brave.crypto page, should now see page rendered normally.

@yrliou yrliou added this to the 1.24.x - Nightly milestone Mar 22, 2021
@yrliou yrliou self-assigned this Mar 22, 2021
@yrliou yrliou requested a review from bbondy March 22, 2021 17:14
@yrliou yrliou added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 23, 2021
@yrliou
Copy link
Member Author

yrliou commented Mar 23, 2021

Apply skip-CI labels to retry on Android only which was the only platform failed.

@yrliou
Copy link
Member Author

yrliou commented Mar 23, 2021

Android build was manually triggered without git cache with help from devops team and it was green, https://ci.brave.com/blue/organizations/jenkins/pr-brave-browser-resolve_method_l10n-android/detail/pr-brave-browser-resolve_method_l10n-android/15/pipeline, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
2 participants