Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ad serving based upon local user browser activity #7881

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Optimize ad serving based upon local user browser activity #7881

merged 1 commit into from
Feb 28, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 9, 2021 •
edited by btlechowski
Loading

Resolves brave/brave-browser#14045

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Detailed test plan: https://github.com/brave/internal/issues/763

Case 1a: Insufficient activity with default triggers

  • verify ad does not show

Case 1b: Sufficient activity with default triggers

  • verify ad does show

Update the triggers parameter by injecting a local seed file or changing the parameter on staging.

Case 2a: Insufficient activity with modified triggers

  • verify ad does not show

Case 2b: Sufficient activity with modified triggers

  • verify ad does show

Case 3: Check all other parameters

@tmancey tmancey requested a review from moritzhaller February 9, 2021 00:04
@tmancey tmancey self-assigned this Feb 9, 2021
@tmancey tmancey force-pushed the issues/14045 branch 12 times, most recently from 77798e5 to d48634a Compare February 9, 2021 02:35
@tmancey tmancey force-pushed the issues/14045 branch 3 times, most recently from e1fa136 to 5bf9c94 Compare February 9, 2021 13:27
moritzhaller
moritzhaller approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per screen share!

@tmancey tmancey force-pushed the issues/14045 branch 2 times, most recently from 61f5000 to 73d73f8 Compare February 9, 2021 15:40
@tmancey tmancey requested a review from nvonpentz February 9, 2021 15:41
@tmancey tmancey force-pushed the issues/14045 branch 4 times, most recently from 7e1c7d1 to 068247a Compare February 10, 2021 09:28
@tmancey tmancey force-pushed the issues/14045 branch 16 times, most recently from 28cdc1f to bf05769 Compare February 16, 2021 22:37
@tmancey tmancey changed the title Improve Brave Ads user activity frequency capping Optimize ad serving based upon user activity Feb 22, 2021
@tmancey tmancey changed the title Optimize ad serving based upon user activity Optimize ad serving based upon local user browser activity Feb 22, 2021
@tmancey tmancey force-pushed the issues/14045 branch 2 times, most recently from a28f954 to 580280f Compare February 22, 2021 17:34
@tmancey
Copy link
Collaborator Author

tmancey commented Feb 25, 2021

CI failed due to know audit deps issue

@tmancey
Copy link
Collaborator Author

tmancey commented Feb 28, 2021

CI failed due to known audit deps

@tmancey tmancey merged commit d065149 into master Feb 28, 2021
@tmancey tmancey deleted the issues/14045 branch February 28, 2021 14:44
@tmancey tmancey added this to the 1.23.x - Nightly milestone Feb 28, 2021
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Apr 9, 2021
Closed
@tmancey tmancey mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@moritzhaller moritzhaller moritzhaller approved these changes

@nvonpentz nvonpentz Awaiting requested review from nvonpentz

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging this pull request may close these issues.

Optimize ad serving based upon local user browser activity
3 participants
@tmancey @kylehickinson @moritzhaller