Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tab id from chrome.tabs.getCurrent to map each tab's torrent state #693

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Use tab id from chrome.tabs.getCurrent to map each tab's torrent state #693

merged 1 commit into from
Oct 22, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 18, 2018 •
edited
Loading

Fix brave/brave-browser#1400

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 18, 2018
@yrliou yrliou changed the title WIP: Use tab id from chrome.tabs.getCurrent to map each tab's torrent state Use tab id from chrome.tabs.getCurrent to map each tab's torrent state Oct 18, 2018
cezaraugusto
cezaraugusto approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, test plan works. ++ nice job!

@yrliou yrliou merged commit 5b891fc into master Oct 22, 2018
yrliou added a commit that referenced this pull request Oct 22, 2018
@yrliou
Merge pull request #693 from brave/fix_focus_change
88b7ded 
Use tab id from chrome.tabs.getCurrent to map each tab's torrent state
@NejcZdovc NejcZdovc deleted the fix_focus_change branch October 22, 2018 20:04
yrliou added a commit that referenced this pull request Oct 22, 2018
@yrliou
Merge pull request #693 from brave/fix_focus_change
a4cea79 
Use tab id from chrome.tabs.getCurrent to map each tab's torrent state
@yrliou
Copy link
Member Author

yrliou commented Oct 22, 2018

master: 5b891fc
0.56.x: 88b7ded
0.57.x: a4cea79

@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #693 from brave/single_process
ba23be6 
Add switch for running tests in single process mode
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Merge pull request #693 from brave/single_process
85bce63 
Add switch for running tests in single process mode
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Merge pull request #693 from brave/single_process
e6165a3 
Add switch for running tests in single process mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

webtorrent page goes blank and displays "loading..." when switching to another application
3 participants
@yrliou @cezaraugusto @bbondy