Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not deliver Brave Ad notifications if we do not have any unblinded tokens - 1.15.x #6710

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Do not deliver Brave Ad notifications if we do not have any unblinded tokens - 1.15.x #6710

merged 1 commit into from
Sep 29, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 26, 2020 •
edited by kjozwiak
Loading

Uplift of #6694
Resolves brave/brave-browser#11789

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team September 26, 2020 11:26
@tmancey tmancey self-assigned this Sep 26, 2020
@tmancey tmancey changed the title Do not deliver Brave Ad notifications if we do not have any unblinded tokens Do not deliver Brave Ad notifications if we do not have any unblinded tokens - 1.15.x Sep 26, 2020
kjozwiak
kjozwiak approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.15.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nighty as per #6694 (comment).

@kjozwiak kjozwiak merged commit c563222 into 1.15.x Sep 29, 2020
@kjozwiak kjozwiak deleted the issues/11789-1.15.x branch September 29, 2020 20:38
@kjozwiak kjozwiak added this to the 1.15.x - Release milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak