Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust compiler to latest stable (1.46.0) #6682

Closed
wants to merge 1 commit into from
Closed

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 22, 2020

Resolves brave/brave-browser#11802
Fixes brave/brave-browser#11782

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this Sep 22, 2020
@tmancey tmancey marked this pull request as draft September 22, 2020 12:31
@tmancey tmancey requested a review from mihaiplesa September 22, 2020 12:39
@tmancey tmancey marked this pull request as ready for review September 22, 2020 12:49
@bsclifton
Copy link
Member

bsclifton commented Sep 22, 2020

Looks like Linux and Android worked - but each ran into an audit_deps problem. Should be good to go! 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ - although let's see if the audit_deps warnings (links above) are a blocker:

For example:

/home/ubuntu/workspace/pr-brave-browser-issues-11802-linux/src/out/Component_audit/../../brave/build/rustup/0.1.5/bin/cargo-audit: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /home/ubuntu/workspace/pr-brave-browser-issues-11802-linux/src/out/Component_audit/../../brave/build/rustup/0.1.5/bin/cargo-audit)

Is this the same as what is captured in brave/brave-browser#7055?

@bsclifton
Copy link
Member

Unless we need this, I think we can close this as cargo-audit 1.12.1 has been published, which pins the version and fixes the error we had seen

@bsclifton bsclifton closed this Sep 22, 2020
@tmancey tmancey deleted the issues/11802 branch June 11, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rust compiler to latest stable (1.46.0) error: could not compile smol_str.
2 participants