Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Rewards service is associated to Tor Profiles - 1.15.x #6607

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 9, 2020

Uplift of #6418
Resolves brave/brave-browser#11223
Resolves brave/brave-browser#11042

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.15.x - Beta milestone Sep 9, 2020
@tmancey tmancey requested a review from a team September 9, 2020 17:29
@tmancey tmancey requested a review from NejcZdovc as a code owner September 9, 2020 17:29
@tmancey tmancey self-assigned this Sep 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2020

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-issues-11223-1.15.x-windows/2/ as build failed as per https://ci.brave.com/job/pr-brave-browser-issues-11223-1.15.x-windows/1/execution/node/169/log/

15:53:24  FAILED: obj/chrome/browser/extensions/api/api_registration/generated_api_registration.obj 

@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2020

test-install failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-issues-11223-1.15.x-windows/2/execution/node/241/log/. However, this is a known intermittent issue that doesn't block uplift.

18:27:50  powershell.exe : Start-Process : This command cannot be run due to the error: The system cannot find the file specified.
18:27:50  At C:\15.x@tmp\durable-a39aedef\powershellWrapper.ps1:3 char:1
18:27:50  + & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...
18:27:50  + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
18:27:50      + CategoryInfo          : NotSpecified: (Start-Process :...file specified.:String) [], RemoteException
18:27:50      + FullyQualifiedErrorId : NativeCommandError
18:27:50   
18:27:50  At C:\15.x@tmp\durable-a39aedef\powershellScript.ps1:10 char:17
18:27:50  + ...             Start-Process "C:\Users\Administrator\AppData\Local\Brave ...
18:27:50  +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
18:27:50      + CategoryInfo          : InvalidOperation: (:) [Start-Process], InvalidOperationException
18:27:50  
18:27:50      + FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.15.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6418 (comment).

@kjozwiak kjozwiak merged commit 1e16e0f into 1.15.x Sep 10, 2020
@kjozwiak kjozwiak deleted the issues/11223-1.15.x branch September 10, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants