-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using PKCE flow for Gemini Authentication, adding shared oauth utility #6306
Conversation
@@ -312,6 +312,12 @@ source_set("browser_process") { | |||
] | |||
} | |||
|
|||
if (gemini_enabled || binance_enabled) { | |||
deps += [ | |||
"//brave/components/crypto_exchange/browser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this module for more code sharing utilities
crypto::kSHA256Length), | ||
&code_challenge); | ||
|
||
if (strip_chars) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for Binance, but Gemini expects characters preserved so these steps are optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f0c72f1
to
8b57ee4
Compare
Using PKCE flow for Gemini Authentication, adding shared oauth utility
Using PKCE flow for Gemini Authentication, adding shared oauth utility
Using PKCE flow for Gemini Authentication, adding shared oauth utility
Verification PASSED on
Went through the following cases via the
|
Fixes brave/brave-browser#11043
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
General authentication regression for Binance and Gemini
Reviewer Checklist:
After-merge Checklist:
changes has landed on.